fix/Broadcast-fail-by-give-queue-kwargs #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because give Broadcast(name='xxx', queue='xxx'), it will create one specific name for queue, and if launch more worker for consuming this queue, this specific name queue already exist then it will not create new queue to binding fanout exchange. So all worker will consuming same queue, and exchange only binding this queue then lose the effect of broadcasting.
|
test fail on Broadcast('test_Broadcast', 'explicit_queue_name'), |
htkuan
force-pushed
the
fix/Broadcast-fail-by-give-queue-kwargs
branch
from
60cbb10 to
4781382
Compare
auvipy
approved these changes
Aug 15, 2018
|
Sorry, I don't understand the "AppVeyor build failed" error. |
|
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because give Broadcast(name='xxx', queue='xxx'),
it will create one specific name for queue,
and if launch more worker for consuming this queue,
this specific name queue already exist then it will not create new queue to
binding fanout exchange.
So all worker will consuming same queue, and exchange only binding this
queue then lose the effect of broadcasting.