-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hypothesis property based testing #264
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REALLY TOUGH TO REVIEW SUCH LARGE DIFF!!
Yes, the examples directory should be ignored when reviewing this. |
Seems like we have a genuine problem with strings inside dictionaries on Python 2.
|
Since Not sure how to resolve this issue. |
Authentication fails with the addition of support for small strings in tables and arrays. Also, tox-docker doesn't seem to work anymore which is super strange. |
Seems like there's a bug in RabbitMQ with short strings in tables. |
I found the source of the problem: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO te existing example based tests should stay on place. we should use property based testing as a complete different suite.
This PR uses hypothesis to check if arrays & dictionaries are serialized and deserialized correctly.
I also fixed our integer serialization and deserialization code, bytes string serialization and small string serialization on tables and arrays.