Add MessageNacked to recoverable errors #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auvipy the CI seems to be totally broken. |
|
initially I was clueless. Later I figured out that it is codecov upload coverage config issue. Also codecov has yanked all its pypi releases. we need to adjust some config in the CI |
|
kombu CI should be stable now. I need to improve this one |
|
@arnaudmorin can you please rebase? |
arnaudmorin
force-pushed
the
dev/am/MessageNacked
branch
from
a3884d1
to
5d28e89
Compare
|
I did rebase, still failing, am I missing something? |
|
it's CI issue |
|
can you pull again? it should be partially working now |
When the broker is answering with a MessageNacked, we can safely retry. Signed-off-by: Arnaud Morin <arnaud.morin@ovhcloud.com> Change-Id: Ica162f29e855637f5677b08f8452dcce879a5056
arnaudmorin
force-pushed
the
dev/am/MessageNacked
branch
from
5d28e89
to
3a2d176
Compare
auvipy
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the broker is answering with a MessageNacked, we can safely retry.
Change-Id: Ica162f29e855637f5677b08f8452dcce879a5056