Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DockerHub and ScaleWay registries #88

Merged
merged 31 commits into from
Nov 20, 2023
Merged

feat: add DockerHub and ScaleWay registries #88

merged 31 commits into from
Nov 20, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Nov 15, 2023

Overview

Part of https://github.com/celestiaorg/devops/issues/124

With this common workflow update, we will have 3 ways where we can fetch newly built containers

  1. Github Registry
  2. Docker Hub
  3. ScaleWay Cloud

In order to fully activate this - we need to revive secrets from the celestiaorg common account in DockerHub and create a new token

https://hub.docker.com/u/celestiaorg

For Scaleway, the secrets are created in 1pass and we only need to transfer the secrets to respective repositories, like:

  • celestia-node
  • celestia-app
  • orchestrator-relayer
  • rollkit/rollkit

In addition to that, common workflows should be called with inheritance like I did here in my own repo
https://github.com/Bidon15/celestia-node/blob/main/.github/workflows/docker-build-publish.yml

Other note is caching. We need it to make builds sub 10 minutes. I've tested them thoroughly in my forks and it works fine as of now in celestia-node.
Meaning that other repos should be fine too

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

closes: https://github.com/celestiaorg/devops/issues/562

@Bidon15 Bidon15 requested review from MSevey and a team as code owners November 15, 2023 12:34
Copy link

mergify bot commented Nov 15, 2023

⚠️ The sha of the head commit of this PR conflicts with #85. Mergify cannot evaluate rules on this PR. ⚠️

tty47
tty47 previously approved these changes Nov 17, 2023
@Bidon15 Bidon15 requested a review from tty47 November 17, 2023 12:18
@Bidon15 Bidon15 changed the title [draft]: try on develop branch feat: add DockerHub and ScaleWay registries #85 Nov 17, 2023
@Bidon15 Bidon15 self-assigned this Nov 17, 2023
@Bidon15 Bidon15 changed the title feat: add DockerHub and ScaleWay registries #85 feat: add DockerHub and ScaleWay registries Nov 17, 2023
tty47
tty47 previously approved these changes Nov 17, 2023
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link

@sysrex sysrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MSevey MSevey merged commit 068cf47 into main Nov 20, 2023
14 checks passed
@MSevey MSevey deleted the develop branch November 20, 2023 19:20
@Bidon15 Bidon15 restored the develop branch November 21, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants