-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DockerHub and ScaleWay registries #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
Co-authored-by: Matthew Sevey <mjsevey@gmail.com>
This reverts commit a2ef4b0.
|
5 tasks
tty47
previously approved these changes
Nov 17, 2023
Bidon15
changed the title
[draft]: try on develop branch
feat: add DockerHub and ScaleWay registries #85
Nov 17, 2023
Bidon15
changed the title
feat: add DockerHub and ScaleWay registries #85
feat: add DockerHub and ScaleWay registries
Nov 17, 2023
tty47
previously approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
MSevey
requested changes
Nov 17, 2023
sysrex
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
MSevey
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Part of https://github.com/celestiaorg/devops/issues/124
With this common workflow update, we will have 3 ways where we can fetch newly built containers
In order to fully activate this - we need to revive secrets from the celestiaorg common account in DockerHub and create a new token
https://hub.docker.com/u/celestiaorg
For Scaleway, the secrets are created in 1pass and we only need to transfer the secrets to respective repositories, like:
In addition to that, common workflows should be called with inheritance like I did here in my own repo
https://github.com/Bidon15/celestia-node/blob/main/.github/workflows/docker-build-publish.yml
Other note is caching. We need it to make builds sub 10 minutes. I've tested them thoroughly in my forks and it works fine as of now in celestia-node.
Meaning that other repos should be fine too
Checklist
closes: https://github.com/celestiaorg/devops/issues/562