Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celestia Core Devs Call 1 #8

Closed
YazzyYaz opened this issue Nov 10, 2023 · 16 comments
Closed

Celestia Core Devs Call 1 #8

YazzyYaz opened this issue Nov 10, 2023 · 16 comments

Comments

@YazzyYaz
Copy link
Contributor

YazzyYaz commented Nov 10, 2023

Celestia Core Devs Call 1

Celestia_Core_Devs_Call

Meeting Information

When: Wednesday, November 29, 5:00 PM CET, 90 minutes max
Where: Celestia Youtube Livestream

Agenda

  • Brief Introduction to Celestia Core Devs Call
  • Client Team Roll Call
    • Consensus
      • Celestia Core/App
    • Data Availability
      • Celestia Node
      • Eiger
  • Overview of CIP-1
  • Electing CIP Editors
    • Yaz Khoury
    • Josh Stein
  • Rough Consensus of moving CIP-1 to Last Call
  • Proposal for Working Groups for non-Core Workstreams
    • DA Working Group
      • Includes Eiger and Celestia Node
      • Propose a Chairman/Chairwoman
    • Interface Working Group
      • Includes rollups like Astria and Eclipse and their work involving working with Node API
      • Includes teams like PK Labs and Modular Cloud and their work involving working with core/app API
      • Propose a Chairman/Chairwoman
  • Consensus-critical minfee proposal
  • Converting ADRs to CIPs for the mechanism behind upgrading for v2 and the signalling mechanism that will be used afterwards
  • Starting CIP for adopting relayer incentivisation middleware
  • Starting a CIP for Gas Refunds
  • Starting a CIP for adopting the Packet Forward Middleware
  • Starting a CIP for the SNARK protected accounts
  • Informational CIP to rename DA to DP
  • CIP to Standardize data expiry time for pruned nodes
  • CIP to capture on-chain governance parameters in a living document

Please post all relevant proposals below that should be discussed and evaluated

@YazzyYaz YazzyYaz changed the title Core Devs Call 1 Celestia Core Devs Call 1 Nov 10, 2023
@jcstein jcstein changed the title Celestia Core Devs Call 1 Celestia Core Devs Call #1 Nov 10, 2023
@jcstein jcstein changed the title Celestia Core Devs Call #1 Celestia Core Devs Call 1 Nov 10, 2023
@fewwwww
Copy link
Contributor

fewwwww commented Nov 15, 2023

Hi, could you also add one more item in the agenda for discussion and evaluation?

@YazzyYaz
Copy link
Contributor Author

@fewwwww for the first call we will primarily focus on CIP-1 so won't have time to go over new proposals yet. I can add this for discussion on the following call. If you can send me a message on telegram (@Yazanator) I can include your proposal in a future call.

@evan-forbes
Copy link
Member

evan-forbes commented Nov 22, 2023

as I see it currently, the most important things to discuss after CIP-1 are:

  • Consensus critical minfee (initial ADR that is will be included in a CIP soon)

    • Makeing the minfee consensus critical
    • How to determine the minimum fee in a dynamic way
    • Where the fee should go
  • Converting ADRs to CIPs for the mechanism behind upgrading for v2 and the signalling mechanism that will be used afterwords

If we have time:

  • Starting a CIP for Gas Refunds

  • Starting a CIP for adopting the Packet Forward Middleware

  • Starting a CIP for the SNARK protected accounts

@womensrights
Copy link
Contributor

Could we also add in to the (if there is time):

Starting a CIP for adopting relayer incentivisation middleware, specification linked here

@Wondertan
Copy link
Member

If we want to include p2p network breaking changes in CIPs(which I am still slightly skeptical about), we should also start a discussion on the new sampling protocol and storage for the node, if time.

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

CIP-1 last call? I don't think so. There are many text mistakes in the doc.

"Preamble: RFC 822 style headers containing metadata about the CIP, including the CIP number, a short descriptive title (limited to a maximum of 44 characters), a description (limited to a maximum of 140 characters), and the author details. Regardless of the category, the title and description should not include the CIP number. See below for details."

It's too short, you see, even the title of Cip-1 "Celestia Improvement Proposal Process and Guidelines" is more than 50 chars.

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

"Reference Implementation (optional): This optional section contains a reference/example implementation that people can use to better understand or implement the specification. This section can be omitted for all CIPs."

here I suggest adding a reference of

"Core CIPs
For Core CIPs, you'll need to either provide a client implementation or persuade clients to implement your CIP, given that client implementations are mandatory for Core CIPs to reach the Final stage (see "CIP Process" below)."

like

"This section can be omitted for all CIPs at initialization (mandatory for Core CIPs to reach the Final stage)."

to avoid confusion.

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

"Each CIP must begin with an RFC 822 style header preamble, preceded and followed by three hyphens (---). This header is also termed “front matter” by Jekyll. The headers must appear in the following order."

remove this because even the CIP-1 itself doesn't comply?

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

"CIP Editor Responsibilities"

maybe, moving this section to CIP-2 is better?

@YazzyYaz
Copy link
Contributor Author

@HoytRen why don't you make a PR instead on these stylistic changes you think should be modified? Easier than commenting on an agenda call which isn't the best way to address the stylistic changes you want to see. CIP-1 is a Markdown file so you can propose a PR with changes and I am happy to review it.

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

Hi @YazzyYaz, I just want to find a place to discuss these before I can do something. Using the forum is better? You see, I feel the length limit is too small, but what's the proper length, I'm not sure. Or we may simply change 'characters' to 'words'?

@YazzyYaz
Copy link
Contributor Author

Just make a PR with your desired changes and we can discuss on the PR. These are literally stylistic or semantic changes. They're not a blocker for CIP-1

@HoytRen
Copy link
Contributor

HoytRen commented Nov 23, 2023

Ok, let me think about the proposal and create a PR tomorrow.

@YazzyYaz
Copy link
Contributor Author

Discussing a CIP for a living document to reference on-chain governance parameters so they're easy to reference within CIP process

@YazzyYaz
Copy link
Contributor Author

Video of Call: https://www.youtube.com/watch?v=EhWHHmPo_5Q
Tweet thread: https://twitter.com/JoshCStein/status/1729893879191621702

@jcstein when you can, your tweet thread is valuable also as a note taking of the call. Maybe making a public notion link for the call as notes from the tweet thread?

@YazzyYaz
Copy link
Contributor Author

Next agenda meeting #22

qubelabsio added a commit that referenced this issue Apr 17, 2024
jcstein added a commit that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants