Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over the relevant tests from the Gravity module #220

Closed
Tracked by #301
evan-forbes opened this issue Feb 20, 2022 · 1 comment
Closed
Tracked by #301

Copy over the relevant tests from the Gravity module #220

evan-forbes opened this issue Feb 20, 2022 · 1 comment
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Feb 20, 2022

Over the course of a few PRs (#208, #212, #215, #218) we've moved and adapted the relevant portions of logic over from the gravity module into the qgb module (on the qgb integration branch).

However, we still need to perform the same treatment to all the relevant unit tests for both business logic and queries. While this may be a bit redundant at first, whenever we introduce any future modifications, this will become absolutely necessary.

We need tests for each method added to the qgb keeper, and we might even want to consider grabbing some of the integration tests too

@evan-forbes evan-forbes moved this to TODO in Celestia Node Feb 20, 2022
@evan-forbes evan-forbes moved this from TODO to Done in Celestia Node Feb 21, 2022
@rach-id rach-id moved this from Done to In Progress in Celestia Node Feb 24, 2022
@rach-id rach-id moved this from In Progress to Done in Celestia Node Mar 11, 2022
@rach-id rach-id moved this from Done to In Progress in Celestia Node Mar 11, 2022
@evan-forbes
Copy link
Member Author

closed by #237

@evan-forbes evan-forbes moved this from In Progress to Done in Celestia Node Mar 14, 2022
@rach-id rach-id closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants