Add basic scaffolding for QGB module #208
Conversation
|
@evan-forbes Please take a look when you have time |
|
@evan-forbes if we need to include: #199 also in this PR. Then, I can turn it into draft to add that stuff |
no that was my mistake, we shouldn't attempt to finish that in this PR. This PR introduces the |
|
@evan-forbes For the |
|
sounds good! |
|
@evan-forbes Can you take a look now please. Removed the dummy field from DataCommitment |
There was a problem hiding this comment.
I think PR is fairly uncontroversial considering that its mostly generated code. Let's change the description so that it doesn't close #197, as we still need another PR to bring over some of the logic of the QGB per #197 (comment)
| option go_package = "github.com/celestiaorg/celestia-app/x/qgb/types"; | ||
|
|
||
| // GenesisState defines the capability module's genesis state. | ||
| message GenesisState {} |
There was a problem hiding this comment.
This is something that we will have to think about in the future, do we want to incorporate the needed validator information in the genesis state, or do we want to add it later.
We're going to have to have some organization around when we actually start the QGB, either at genesis or at a later block height.
tbc, nothing todo in this PR, just talking out loud.
|
@evan-forbes Should we merge this one, then add the remaining logic in the next PR ? |
yep! I think so |
Description
Adds basic scaffolding for the QGB module.
closes #197
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes