Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0 doesn't contain pre-built binaries #2749

Closed
rootulp opened this issue Oct 23, 2023 · 1 comment
Closed

v1.2.0 doesn't contain pre-built binaries #2749

rootulp opened this issue Oct 23, 2023 · 1 comment
Assignees
@rootulp
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 23, 2023 •
edited
Loading

Problem

The v1.2.0 release doesn't contain pre-built binaries b/c markdown link check failed here and that's a prerequisite for version bump (which is a prerequisite for goreleaser)

Proposal

  1. Remove markdown-linter as a prerequisite from version bump

    celestia-app/.github/workflows/ci-release.yml

    Lines 52 to 53 in c0743df

    version_bump:
    needs: [lint, markdown-linter, test]
  2. Fix the broken QGB links

Note: we can only re-run the CI workflow on v1.2.0 without modifications and I don't expect that to succeed so we'd have to do something hacky to get pre-built binaries attached to v1.2.0. We can fix this so we don't hit it on subsequent releases.
@rootulp rootulp added the bug Something isn't working label Oct 23, 2023
@rootulp rootulp self-assigned this Oct 23, 2023
@rootulp rootulp changed the title v1.2.0 doesn't contain v1.2.0 doesn't contain pre-built binaries Oct 23, 2023
This was referenced Oct 23, 2023
Merged
Merged
rootulp added a commit that referenced this issue Oct 23, 2023
@rootulp
ci: remove markdown-linter as prerequisite to version bump (#2751)
6d8eeec 
Part of #2749

The markdown-linter job contains markdown-link-check which is super
flakey. If it fails on a release then the pre-built binaries won't be
generated and attached to the release.
rootulp added a commit that referenced this issue Nov 6, 2023
@rootulp
docs: use QGB permalinks to appease markdown link check (#2750)
9cae513 
Part of #2749 

Note: we've discussed avoiding backporting docs changes so we can close
this PR if we're okay with markdown link check failing on the v1.x
branch from now on.

## Testing

On the v1.x branch, locally `make markdown-link-check` passes
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 16, 2023

The 1.2.0 release still doesn't contain the pre-built binaries but we took steps to avoid this for future releases via #2750 and #2751.

@rootulp rootulp closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp