Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate test settings for enhanced e2e benchmarking test scenario management #3363

Closed
staheri14 opened this issue Apr 22, 2024 · 0 comments · Fixed by #3395
Closed

Consolidate test settings for enhanced e2e benchmarking test scenario management #3363

staheri14 opened this issue Apr 22, 2024 · 0 comments · Fixed by #3395
Assignees
@staheri14
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@staheri14
Copy link
Contributor

In the e2e benchmarking tests, the test scenario is defined by a core set of parameters that influence the performance evaluation of the experiments. These parameters vary in nature; some are configuration settings, some are consensus/p2p parameters, and others define the network topology, etc. Consolidating these parameters in a single struct and ensuring that each testnet is associated with one and use that when setting up nodes, configurations, and parameters will simplify the process for test developers. This also facilitates the comparison of different test scenarios.

This issue aims to perform the necessary refactoring to achieve this.
@staheri14 staheri14 self-assigned this Apr 22, 2024
@staheri14 staheri14 added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Apr 22, 2024
This was referenced Apr 24, 2024
Closed
Merged
Merged
staheri14 added a commit that referenced this issue May 13, 2024
@staheri14
test(e2e benchmark): introduces test manifest and its related utiliti…
ef67d05 
…es (#3391)

The first PR towards #3363 
Closes #3457

There will be an additional follow-up PR to further refactor the
`E2EThroughput`.

The `E2EThroughput` has been successfully tested (with the changes in
this PR) and is functioning properly.
You may run: 
```
go run ./test/e2e/benchmark  -v
```
staheri14 added a commit that referenced this issue May 17, 2024
@staheri14
test(e2e benchmark): refactors E2EThroughput (#3395)
fc49336 
A follow-up PR for #3391 that addresses and closes #3363.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Milestone
No milestone
1 participant
@staheri14