Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate authored blobs to v3 if we don't use multi-app #3771

Closed
evan-forbes opened this issue Aug 9, 2024 · 2 comments
Closed

Gate authored blobs to v3 if we don't use multi-app #3771

evan-forbes opened this issue Aug 9, 2024 · 2 comments
Assignees
Labels
required issue is required to be closed before workstream can be closed WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Milestone

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 9, 2024

in #3765, we added authored blobs, a consensus breaking feature, but didn't gate it like normal due to the ongoing switch to a new upgrade mechanism.

if we don't end up using that mechanism, we need to make sure that we gate it appropriately.

this issue can be closed upon using the new upgrade mechanism or by adding the gating mechanism and a unit test (preferably also a e2e test) for the upgrade #3772

@evan-forbes evan-forbes added the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Aug 9, 2024
@rootulp rootulp changed the title Gate authored blobs to v3 if we don't switch upgrade mechanisms Gate authored blobs to v3 if we don't use multi-app Sep 3, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 3, 2024

Slight correction: multi-app doesn't change the upgrade mechanism. The upgrade from v2 -> v3 and onwards will still use signaling.

We need to gate authored blobs to v3 if we don't adopt a refactor to how the celestia-app binary supports multiple state machines. That refactor is sometimes called "multi-app".

@rootulp rootulp added this to the v3 milestone Sep 11, 2024
@evan-forbes evan-forbes added the required issue is required to be closed before workstream can be closed label Sep 12, 2024
@rootulp rootulp self-assigned this Sep 30, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 30, 2024

This appears closed by #3870. @cmwaters please re-open if I'm mistaken.

@rootulp rootulp closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
required issue is required to be closed before workstream can be closed WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Development

No branches or pull requests

3 participants