Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an e2e major upgrade test for v3 #3772

Closed
evan-forbes opened this issue Aug 9, 2024 · 0 comments · Fixed by #3910
Closed

Add an e2e major upgrade test for v3 #3772

evan-forbes opened this issue Aug 9, 2024 · 0 comments · Fixed by #3910
Assignees
@rootulp
Labels
required issue is required to be closed before workstream can be closed testing items that are strictly related to adding or extending test coverage WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Milestone
v3

Comments

@evan-forbes
Copy link
Member

similar to how we test for an upgrade to v2, we should also test for the upgrade to v3

this could be done by modifying the existing test to handle multiple versions or by creating a new test. If a new test is created, ideally it should handle all future signalling based upgrades.
@evan-forbes evan-forbes added testing items that are strictly related to adding or extending test coverage WS: V3 3️⃣ item is directly relevant to the v3 hardfork labels Aug 9, 2024
This was referenced Aug 9, 2024
Closed
Merged
@rootulp rootulp added this to the v3 milestone Sep 12, 2024
@evan-forbes evan-forbes added the required issue is required to be closed before workstream can be closed label Sep 12, 2024
@rootulp rootulp assigned rootulp and unassigned cmwaters Sep 30, 2024
@rootulp rootulp mentioned this issue Sep 30, 2024
Merged
@rootulp rootulp closed this as completed in 206b96c Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
required issue is required to be closed before workstream can be closed testing items that are strictly related to adding or extending test coverage WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

test: v3 e2e upgrade celestiaorg/celestia-app
4 participants
@rootulp @cmwaters @evan-forbes and others