chore: specifies minimum square size in non-interactive default rules #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
Feb 23, 2023
rootulp
approved these changes
Feb 23, 2023
liamsi
approved these changes
Feb 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to clarify that the minimum square size in non-interactive default rules should be a power of 2. For example, for a message of length 23, the minimum square size is
8*8(but not5*5). (based on a discussion in Slack)New and updated code has appropriate documentationNew and updated code has new and/or updated testingVisual proof for any user facing features like CLI or documentation updatesLinked issues closed with keywords