chore: ban naked returns #1865
Merged
chore: ban naked returns #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
chore
rootulp
commented
May 31, 2023
|
|
||
| linters-settings: | ||
| nakedret: | ||
| # Ban the use of naked returns because they reduce code readability. |
There was a problem hiding this comment.
note: this is subjective but I expect the linter will reduce the # of nits / comments on PRs which is a net positive
rach-id
approved these changes
May 31, 2023
evan-forbes
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation #1770 (comment).
Today I learned that a linter exists to ban naked returns.