chore!: remove unused fitsInRow return value #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 21.21% 21.22% +0.01%
==========================================
Files 120 120
Lines 13693 13695 +2
==========================================
+ Hits 2905 2907 +2
Misses 10498 10498
Partials 290 290
|
rootulp
requested changes
Jun 14, 2023
rootulp
added
the
chore
evan-forbes
added
the
warn:api breaking
evan-forbes
previously approved these changes
Jun 14, 2023
rootulp
approved these changes
Jun 14, 2023
evan-forbes
approved these changes
Jun 15, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Jul 3, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextShareIndexalso returns a boolean "fitsInRow" value which isn't used anywhere in the logic anymore. This PR cleans up the function by removing it. Note that this breaks the Go API