docs: add a link to the tokenfilter in the spec ToC #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
liamsi,
adlerjohn,
MSevey,
evan-forbes and
rootulp
as code owners
|
evan-forbes
previously approved these changes
Jun 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #1924 +/- ##
=======================================
Coverage 21.21% 21.21%
=======================================
Files 120 120
Lines 13693 13693
=======================================
Hits 2905 2905
Misses 10498 10498
Partials 290 290 |
rootulp
requested changes
Jun 14, 2023
| @@ -15,3 +15,4 @@ | |||
| - [mint](../../x/mint/README.md) | |||
| - [paramfilter](../../x/paramfilter/README.md) | |||
| - [upgrade](../../x/upgrade/README.md) | |||
| - [tokenfilter](../../x/tokenfilter/README.md) | |||
There was a problem hiding this comment.
I suspect we also want to add it after:
celestia-app/specs/src/SUMMARY.md
Line 19 in 766b8a5
There was a problem hiding this comment.
Thanks for pointing those other areas out. I've added a link in those places now
rootulp
added
documentation
rootulp
approved these changes
Jun 14, 2023
evan-forbes
approved these changes
Jun 14, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Jun 14, 2023
* docs: add a link to the tokenfilter in the spec ToC * add reference to the token filter in other parts of the spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.