Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename to namespace padding #1929

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 14, 2023

Closes #1926

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Jun 14, 2023
@rootulp rootulp added this to the Post-mainnet milestone Jun 14, 2023
@rootulp rootulp self-assigned this Jun 14, 2023
@MSevey MSevey requested a review from a team June 14, 2023 14:44
@codecov-commenter
Copy link

Codecov Report

Merging #1929 (6f86029) into main (376a1d4) will decrease coverage by 0.64%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   21.85%   21.21%   -0.64%     
==========================================
  Files         117      120       +3     
  Lines       13304    13693     +389     
==========================================
- Hits         2907     2905       -2     
- Misses      10107    10498     +391     
  Partials      290      290              
Impacted Files Coverage Δ
pkg/shares/share_splitting.go 41.93% <0.00%> (ø)
pkg/square/builder.go 77.22% <0.00%> (ø)
pkg/shares/split_sparse_shares.go 38.46% <25.00%> (ø)

... and 12 files with indirect coverage changes

@rootulp rootulp enabled auto-merge (squash) June 14, 2023 17:37
@rootulp rootulp merged commit 8f077ee into celestiaorg:main Jun 15, 2023
@evan-forbes evan-forbes added the warn:api breaking item will be break an API and require a major bump label Jun 15, 2023
@rootulp rootulp deleted the rp/rename-namespaced-padded branch June 15, 2023 16:02
evan-forbes pushed a commit that referenced this pull request Jul 3, 2023
evan-forbes pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit warn:api breaking item will be break an API and require a major bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename NamespacedPaddedShares to NamespacePaddingShares
4 participants