fix: links to modules in specs #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tungbq
requested review from
liamsi,
adlerjohn,
evan-forbes,
rootulp and
cmwaters
as code owners
|
hmm the links on the sidebar still appear broken |
rootulp
approved these changes
Jul 12, 2023
Comment on lines
-17
to
-22
| - [blob](../../x/blob/README.md) | ||
| - [qgb](../../x/qgb/README.md) | ||
| - [mint](../../x/mint/README.md) | ||
| - [paramfilter](../../x/paramfilter/README.md) | ||
| - [upgrade](../../x/upgrade/README.md) | ||
| - [tokenfilter](../../x/tokenfilter/README.md) |
There was a problem hiding this comment.
[note for reviewers] this removes the links from the sidebar b/c it looks like mdbook expects these to be relative to the specs site
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
=======================================
Coverage 21.50% 21.50%
=======================================
Files 127 127
Lines 14316 14316
=======================================
Hits 3079 3079
Misses 10940 10940
Partials 297 297 |
rootulp
changed the title
rootulp
requested review from
rach-id
and removed request for
adlerjohn,
liamsi and
evan-forbes
rach-id
approved these changes
Jul 12, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #2093
Checklist