chore: add test for tx priority #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
testing
evan-forbes
added
the
backport:v1.x
rootulp
previously approved these changes
Aug 31, 2023
|
Maybe also closes #2377 |
staheri14
previously approved these changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #2394 +/- ##
==========================================
- Coverage 20.62% 20.60% -0.02%
==========================================
Files 131 131
Lines 15266 15276 +10
==========================================
Hits 3148 3148
- Misses 11816 11826 +10
Partials 302 302
|
rootulp
approved these changes
Aug 31, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## Overview adds a simple integration test for tx priority in the mempool closes #513 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: Rootul Patel <rootulp@gmail.com> (cherry picked from commit 58c1e4e) # Conflicts: # Makefile
evan-forbes
added a commit
that referenced
this pull request
Sep 13, 2023
This is an automatic backport of pull request #2394 done by [Mergify](https://mergify.com). Cherry-pick of 58c1e4e has failed: ``` On branch mergify/bp/v1.x/pr-2394 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit 58c1e4e. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: new file: app/test/priority_test.go modified: pkg/user/tx_options.go Unmerged paths: (use "git add <file>..." to mark resolution) both modified: Makefile ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com> Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds a simple integration test for tx priority in the mempool
closes #513 #2377
Checklist