-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the orchestrator/relayer commands, adds tests and moves Ethereum/Orchestrator addresses to cosmos-sdk.staking.Validator #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
…rg/lazyledger-app into evan/orchestrator-orchestrator
* adds overview and valset init ADRs * cleanup * adds Data commitment ADR init * improves the valset adr * cosmetics * adds more details and removes unnecessary stuff * cosmetics * proto format + ADR updates * updates proto files + ADR * adds endblocker doc to adr * typo
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
…rg/lazyledger-app into evan/orchestrator-orchestrator
…azyledger-app into evan/testable-orchestrator
…azyledger-app into evan/testable-orchestrator
…azyledger-app into evan/testable-orchestrator
…azyledger-app into evan/testable-orchestrator
This was referenced Apr 10, 2022
Closed
Closed
Closed
* removing setting the address separatly and relying on the eth/orch addresses to be defined in sdk.staking.Validator * add tx command for qgb module * added proto generated files * fixes tests * adds todo * todo * pass the keyring backend and path to app client * adds error check the newKeyedTransactorWithChainId * rename QueryLastValset1 to QueryLastValsetRequests * rename evmChainIDFlag typo * rename QueryLastValsets * adds todo * update deploy command to use the right latest valset * adds todo * updated go.mod and go.sum * update the single-node.sh script to initialize three accounts and create one validator with an orchestrator and ethereum address * imports * adds events testing main.go * remove unused variable * use sweexordious fork for cosmos sdk in the app * update go.sum * update .gitignore * update lint.yml * linter fixes * new line * linter * todo * linter checks * linter checks * linter checks * adds mutexes for race conditions
rach-id
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change the title and merge
This was
linked to
issues
Apr 14, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
May 9, 2022
…reum/Orchestrator addresses to cosmos-sdk.staking.Validator (celestiaorg#276) * initial orchestrator client * format proto and add necessary queries * add orchestrator logic * and encoding of data commitments and validator set changes * add orchestrator command * add relayer * add the orchestrator command * proto formatting * use correct name Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> * use correct path to endpoint Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> * get rid of GravityNonces struct * use correct name Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> * Adds QGB related ADRs (celestiaorg#250) * adds overview and valset init ADRs * cleanup * adds Data commitment ADR init * improves the valset adr * cosmetics * adds more details and removes unnecessary stuff * cosmetics * proto format + ADR updates * updates proto files + ADR * adds endblocker doc to adr * typo * regenerate proto * go mod tidy * use correct name Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> * handle error * begin refactor * adds data commitments and valset orchestrator processors * add the app client that queries for validator sets and data commitments * add two new methods * add query methods to appClient * WIP: update orchestrator and relayer to use the appClient * WIP: update orchestrator and relayer to use the appClient * WIP: update orchestrator and relayer to use the appClient * adds evm_client implementation * add the nil clients for the evm and mockappclient * add the new methods to the mock app client * flesh out the mock app client * flesh out app orchestrator test * adds QueryLatestValset to appClient * wip: adds orchestrator test * adds orchestrator valset test * moves orchestrator test utils to a separate file * adds orchestrator valset processEvents error check in test * rename ValidatorSignature field in DataCommitmentConfirm to ValidatorAddress * fix valset orchestrator signature test * fix last valset request in orchestrator * fix last valset request in orchestrator common test * remove unnecessary nonce increment for data commitment signing in orchestrator * fix orchestrator data commitment test * closes the mocked app client in orchestrator test * add the mock evm client * fix the command to orchestrate valsets properly * get rid of zerologger * use tmlog instead of zerolog * remove extra err handling * add comment to question nonce usage in evm client submit dataroot * adds data commitment orchestrator test * adds deploy command * adds evmRpc flag to qgb config * deubgging the qgb install * add set orchestrator command * removes set Ethereum/Orch address + fixes tests + general cleanup (celestiaorg#296) * removing setting the address separatly and relying on the eth/orch addresses to be defined in sdk.staking.Validator * add tx command for qgb module * added proto generated files * fixes tests * adds todo * todo * pass the keyring backend and path to app client * adds error check the newKeyedTransactorWithChainId * rename QueryLastValset1 to QueryLastValsetRequests * rename evmChainIDFlag typo * rename QueryLastValsets * adds todo * update deploy command to use the right latest valset * adds todo * updated go.mod and go.sum * update the single-node.sh script to initialize three accounts and create one validator with an orchestrator and ethereum address * imports * adds events testing main.go * remove unused variable * use sweexordious fork for cosmos sdk in the app * update go.sum * update .gitignore * update lint.yml * linter fixes * new line * linter * todo * linter checks * linter checks * linter checks * adds mutexes for race conditions Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP refactor of the orchestrator and relayer to make testing easier