Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually print version on version sub-command #360

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix: actually print version on version sub-command #360

merged 1 commit into from
Apr 27, 2022

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Apr 27, 2022

Description

closes: #357

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@liamsi liamsi requested a review from evan-forbes April 27, 2022 21:12
@liamsi liamsi mentioned this pull request Apr 27, 2022
Closed
@liamsi liamsi requested a review from adlerjohn April 27, 2022 21:12
evan-forbes
evan-forbes approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

tested locally

@liamsi liamsi merged commit 07816a7 into master Apr 27, 2022
@liamsi liamsi deleted the liamsi/print_version branch April 27, 2022 21:24
@rootulp rootulp mentioned this pull request Jul 29, 2022
Closed
@adlerjohn adlerjohn mentioned this pull request May 14, 2023
Merged
5 tasks
adlerjohn added a commit that referenced this pull request May 14, 2023
@adlerjohn
Remove shebang from Makefile. (#1764)
07851ee 
## Overview

#360 introduced a
[shebang](https://en.wikipedia.org/wiki/Shebang_(Unix)) incorrectly. The
shebang is only used for executable files (from the Wikipedia link
above, emphasis mine):

> When a text file with a shebang is used **as if it is an executable**
in a Unix-like operating system, the program loader mechanism parses the
rest of the file's initial line as an interpreter directive.

Makefiles aren't self-executable, rather they're inputs to the `make`
command.

## Checklist

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
@rootulp rootulp mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print a version of the app with the version sub command
2 participants
@liamsi @evan-forbes