Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(e2e test): extends the wait time for genesis nodes to produce the first block #3611

Merged
merged 2 commits into from
Jun 24, 2024
Merged

chore(e2e test): extends the wait time for genesis nodes to produce the first block #3611

merged 2 commits into from
Jun 24, 2024

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Jun 21, 2024 •
edited
Loading

Closes #3610
Part of #3557

@staheri14 staheri14 changed the title chore(e2e test): extends the wait time for genesis nodes to produce the first block in e2e tests #3610 chore(e2e test): extends the wait time for genesis nodes to produce the first block Jun 21, 2024
@staheri14 staheri14 self-assigned this Jun 21, 2024
@staheri14 staheri14 added the chore optional label for items that follow the `chore` conventional commit label Jun 21, 2024
@staheri14 staheri14 marked this pull request as ready for review June 21, 2024 16:51
@staheri14 staheri14 requested a review from a team as a code owner June 21, 2024 16:51
@staheri14 staheri14 requested review from rootulp and cmwaters and removed request for a team June 21, 2024 16:51
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 21, 2024 •
edited
Loading

Walkthrough

Walkthrough

The primary change increases the sleep time from 100 milliseconds to 1000 milliseconds in the Start() method of the Testnet struct within testnet.go. This modification ensures that the genesis nodes have adequate time to produce the first block in e2e tests, addressing issues with nondeterministic test failures.

Changes

File Change Summary
test/e2e/testnet/... Increased sleep time from 100 to 1000 milliseconds in the Start() method of the Testnet struct.

Assessment against linked issues

Objective Addressed Explanation
Extend the wait time for genesis nodes to produce the first block in e2e tests (Issue #3610) ✅
Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04d79a7 and 57911b5.

Files selected for processing (1)
  • test/e2e/testnet/testnet.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • test/e2e/testnet/testnet.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

rootulp
rootulp previously approved these changes Jun 21, 2024
View reviewed changes
test/e2e/testnet/testnet.go Outdated
@@ -367,7 +367,7 @@ func (t *Testnet) Start() error {
return fmt.Errorf("failed to start node %s", node.Name)
}
fmt.Printf("node %s is not synced yet, waiting...\n", node.Name)
time.Sleep(100 * time.Millisecond)
time.Sleep(1000 * time.Millisecond)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] seems more readable

Suggested change
time.Sleep(1000 * time.Millisecond)
time.Sleep(10 * time.Second)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the unit from milliseconds to seconds.
Since this loop iterates 10 times and checks the node's status in each iteration, to achieve a total wait time of 10 seconds, the wait time for each iteration should be adjusted to 1 second.

@celestia-bot celestia-bot requested a review from a team June 21, 2024 18:09
@staheri14 staheri14 requested a review from rootulp June 21, 2024 18:11
@staheri14 staheri14 merged commit c53add4 into main Jun 24, 2024
32 checks passed
@staheri14 staheri14 deleted the sanaz/increase-wait-time branch June 24, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninabarbakadze ninabarbakadze ninabarbakadze approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@rootulp rootulp rootulp approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters cmwaters is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@staheri14 staheri14

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the wait time for genesis nodes to produce the first block in e2e tests
4 participants
@staheri14 @rootulp @evan-forbes @ninabarbakadze