Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run make test-interchain in CI #3643

Merged
merged 15 commits into from
Jul 1, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 28, 2024

Closes #3358

Testing

Passes locally and in CI

@rootulp rootulp self-assigned this Jun 28, 2024
Hitting this error in CI:

```
failed to create faucet accounts: failed
to create common account with name faucet: failed to create key with
name "faucet" on chain gaia-2: exit code 1:  exec /bin/gaiad: exec
format error
```

I think because the Docker image I had for Gaia only works on arm64
machines and Github action runner is x86
@rootulp rootulp marked this pull request as ready for review June 28, 2024 21:14
@rootulp rootulp requested a review from a team as a code owner June 28, 2024 21:14
Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

This update integrates interchain testing into the CI process of the project. The primary changes involve adding a new GitHub Actions workflow to build and test Docker images for Celestia and Cosmos. Additionally, modifications were made to the Makefile and test specifications for Docker repositories and tags, enhancing automation and consistency in testing interchain dependencies.

Changes

Files/Paths Change Summaries
.github/.../ci-release.yml Added a new job test-interchain to run interchain tests using an external workflow file.
.github/.../test-interchain.yml Introduced a new workflow for building Docker images and running interchain tests.
Makefile Added a reminder to rebuild the Docker image for recent code changes in the test-interchain target.
test/.../chainspec/celestia.go Updated Docker repository and tag for Celestia to remove prefix and set the tag to "latest".
test/.../chainspec/cosmosHub.go Updated Cosmos Docker repository and version to use the official release.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHubActions
    participant DockerHub
    participant CI-Environment
    
    Developer->>+GitHubActions: Push changes
    GitHubActions->>+DockerHub: Build and push Docker images
    GitHubActions->>+CI-Environment: Trigger `test-interchain` job
    CI-Environment->>+DockerHub: Pull built Docker images
    CI-Environment->>+TestSuite: Run interchain tests
    TestSuite-->>CI-Environment: Return test results
    CI-Environment-->>GitHubActions: Report status
    GitHubActions-->>Developer: Test results notification
Loading

Assessment against linked issues

Objective (from Issue #3358) Addressed Explanation
Integrate interchain tests into CI pipeline
Update tests to use the Docker image built from PR contents
Add workflow to run make test-interchain in CI

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Jun 28, 2024
Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rootul!

@celestia-bot celestia-bot requested review from a team, ramin and staheri14 and removed request for a team July 1, 2024 09:38
@rootulp rootulp merged commit 7ee7290 into celestiaorg:main Jul 1, 2024
33 of 34 checks passed
@rootulp rootulp deleted the rp/ci-interchaintest branch July 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run interchain tests via CI
4 participants