Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testnode): remove duplicate consensus params #3687

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 16, 2024

Closes #3684

@rootulp rootulp self-assigned this Jul 16, 2024
@rootulp rootulp marked this pull request as ready for review July 16, 2024 17:36
@rootulp rootulp requested a review from a team as a code owner July 16, 2024 17:36
@rootulp rootulp requested review from cmwaters and ninabarbakadze and removed request for a team July 16, 2024 17:36
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Walkthrough

Walkthrough

The primary modification involves updating the DefaultConfig function in test/util/testnode/config.go by removing the line that sets ConsensusParams after SuppressLogs. This change aims to eliminate a duplicate initialization of consensus parameters, thereby optimizing the configuration process.

Changes

File Change Summary
test/util/testnode/config.go Removed the line WithConsensusParams(DefaultConsensusParams()) from the DefaultConfig function to eliminate duplicate initialization of consensus parameters.

Assessment against linked issues

Objective Addressed Explanation
Remove duplicate consensus params for testnode (#3684)

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8cb10b6 and 87c1481.

Files selected for processing (1)
  • test/util/testnode/config.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • test/util/testnode/config.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested a review from evan-forbes July 16, 2024 17:36
@rootulp rootulp enabled auto-merge (squash) July 16, 2024 17:37
evan-forbes
evan-forbes previously approved these changes Jul 17, 2024
@rootulp rootulp requested a review from evan-forbes July 17, 2024 19:01
@rootulp rootulp merged commit 9407a5b into celestiaorg:main Jul 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate consensus params for testnode
3 participants