Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Name to Account #3690

Merged
merged 2 commits into from
Jul 17, 2024
Merged

test: add Name to Account #3690

merged 2 commits into from
Jul 17, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 16, 2024

There are a few places in celestia-node where I want to use the account names from testnode but they weren't persisted/exposed prior to this PR.

@rootulp rootulp added the backport:v2.x PR will be backported automatically to the v2.x branch upon merging label Jul 16, 2024
@rootulp rootulp self-assigned this Jul 16, 2024
@rootulp rootulp requested a review from a team as a code owner July 16, 2024 20:59
@rootulp rootulp requested review from cmwaters and ninabarbakadze and removed request for a team July 16, 2024 20:59
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024 •
edited
Loading

Walkthrough

Walkthrough

The update introduces a new Name field to the Account struct across multiple files, enhancing account information by including user names. Methods that handle accounts now include checks to ensure the Name field is not empty, improving data validation and integrity within the application.

Changes

Files Change Summary
test/util/genesis/document.go Added Name field to Account struct and updated checks.
test/util/genesis/genesis.go Added Name field to Account struct and updated checks.
test/util/test_app.go Added Name field to Account struct and updated checks.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested a review from evan-forbes July 16, 2024 20:59
@celestia-bot celestia-bot requested a review from a team July 16, 2024 20:59
@rootulp rootulp enabled auto-merge (squash) July 16, 2024 21:08
@rootulp rootulp merged commit e7b5d8f into celestiaorg:main Jul 17, 2024
34 checks passed
@rootulp rootulp deleted the rp/account-name branch July 17, 2024 14:46
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
@rootulp @mergify
test: add Name to Account (#3690)
1bee957 
There are a few places in celestia-node where I want to use the account
names from testnode but they weren't persisted/exposed prior to this PR.

(cherry picked from commit e7b5d8f)
@mergify mergify bot mentioned this pull request Jul 17, 2024
Merged
rootulp added a commit that referenced this pull request Jul 17, 2024
@mergify @rootulp
test: add Name to Account (backport #3690) (#3695)
76cd246 
There are a few places in celestia-node where I want to use the account
names from testnode but they weren't persisted/exposed prior to this
PR.<hr>This is an automatic backport of pull request #3690 done by
[Mergify](https://mergify.com).

Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp rootulp mentioned this pull request Jul 18, 2024
Merged
rootulp added a commit that referenced this pull request Jul 19, 2024
@rootulp
fix(test/e2e): name cannot be empty error (#3706)
acf7fc1 
Recent e2e tests failed with:

```
2024/07/18 17:22:08 Failed to setup testnet: converting accounts into sdk types: invalid account 4: name cannot be empty
```

because #3690 merged.
Since e2e tests aren't run as part of CI on each PR, I didn't learn
about the failure until @ninabarbakadze pinged about it.

## Testing

```
make test-e2e
```

gets past that error locally.
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
@rootulp @mergify
fix(test/e2e): name cannot be empty error (#3706)
c488f3d 
Recent e2e tests failed with:

```
2024/07/18 17:22:08 Failed to setup testnet: converting accounts into sdk types: invalid account 4: name cannot be empty
```

because #3690 merged.
Since e2e tests aren't run as part of CI on each PR, I didn't learn
about the failure until @ninabarbakadze pinged about it.

## Testing

```
make test-e2e
```

gets past that error locally.

(cherry picked from commit acf7fc1)
@mergify mergify bot mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninabarbakadze ninabarbakadze ninabarbakadze approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters cmwaters is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rootulp rootulp

Labels
backport:v2.x PR will be backported automatically to the v2.x branch upon merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rootulp @evan-forbes @ninabarbakadze