-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error log to txstatus (backport #3788) #3789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview - [x] Bump celestia-core verison including refactored TxStatus work - [x] Extend the rpc response to return the error log - [x] Update TxClient with extended TxStatus struct --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit 02b604d) # Conflicts: # app/test/big_blob_test.go # app/test/prepare_proposal_context_test.go # app/test/square_size_test.go # app/test/std_sdk_test.go # pkg/user/tx_client.go # pkg/user/tx_client_test.go # x/blobstream/integration_test.go # x/signal/legacy_test.go
Cherry-pick of 02b604d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
evan-forbes
approved these changes
Aug 20, 2024
rootulp
approved these changes
Aug 20, 2024
celestia-bot
requested review from
a team and
staheri14
and removed request for
a team
August 20, 2024 20:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ended up cherry picking #3790 to make it easier for the reviewer