ci: use goreleaser-cross for goreleaser-check command #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
backport:v2.x
rootulp
requested review from
rach-id and
ninabarbakadze
and removed request for
a team
WalkthroughWalkthroughThe changes involve modifications to the GitHub Actions workflow, the Goreleaser configuration, and the Makefile. The workflow file is updated to pin the Goreleaser action to a specific major version for stability. The naming convention for snapshots in the configuration is altered by replacing Changes
Assessment against linked issues
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Files skipped from review as they are similar to previous changes (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
rootulp
changed the title
rootulp
changed the title
rootulp
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
Makefile (1)
194-196: Consider improving the error message formatting.The error message could be formatted for better readability by breaking it into multiple lines or using a heredoc.
Consider using a heredoc for the error message:
@if [ ! -f ".release-env" ]; then \ cat <<EOF A .release-env file was not found but is required to create prebuilt binaries. This command is expected to be run in CI where a .release-env file exists. If you need to run this command locally to attach binaries to a release, you need to create a .release-env file with a Github token (classic) that has repo:public_repo scope. EOF exit 1; \ fi
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Closes #3805 [goreleaser v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0) deprecated the `name_template` field in favor of `version_template`. Our goreleaser-check command used a GH action that was using goreleaser v2.2.0 so we fixed the deprecation in #3797 but the make prebuilt-binary command uses goreleaser-cross which was using a previous version of goreleaser that fails for the new field. This PR updates the goreleaser-check command to use the goreleaser-cross Docker image so that the check command and prebuilt-binary command uses the same version. Note: we'll need to update `name_template` to `version_template` when we upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which bumped to goreleaser 2.22.0. See goreleaser/goreleaser-cross#77 (cherry picked from commit 13f3098)
rootulp
added a commit
that referenced
this pull request
Aug 22, 2024
#3813) Closes #3805 [goreleaser v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0) deprecated the `name_template` field in favor of `version_template`. Our goreleaser-check command used a GH action that was using goreleaser v2.2.0 so we fixed the deprecation in #3797 but the make prebuilt-binary command uses goreleaser-cross which was using a previous version of goreleaser that fails for the new field. This PR updates the goreleaser-check command to use the goreleaser-cross Docker image so that the check command and prebuilt-binary command uses the same version. Note: we'll need to update `name_template` to `version_template` when we upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which bumped to goreleaser 2.22.0. See https://github.com/goreleaser/goreleaser-cross/pull/77<hr>This is an automatic backport of pull request #3806 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3805
goreleaser v2.2.0 deprecated the
name_templatefield in favor ofversion_template. Our goreleaser-check command used a GH action that was using goreleaser v2.2.0 so we fixed the deprecation in #3797 but the make prebuilt-binary command uses goreleaser-cross which was using a previous version of goreleaser that fails for the new field.This PR updates the goreleaser-check command to use the goreleaser-cross Docker image so that the check command and prebuilt-binary command uses the same version.
Note: we'll need to update
name_templatetoversion_templatewhen we upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which bumped to goreleaser 2.22.0. See goreleaser/goreleaser-cross#77