ci(goreleaser): fix release candidate suffix #3833
Conversation
rootulp
added
the
backport:v2.x
rootulp
changed the title
rootulp
requested review from
staheri14 and
rach-id
and removed request for
a team
WalkthroughWalkthroughThe changes involve modifying the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Additional context usedLanguageTool
Additional comments not posted (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
rootulp
changed the title
rootulp
requested review from
cmwaters,
evan-forbes and
ninabarbakadze
and removed request for
liamsi
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
docs/maintainers/prebuilt-binaries.md (1)
14-16: Consider using a different verb for a more formal wording.The phrase "fix the issue that occurred" can be improved for formality.
Apply this diff to improve formality:
- If you need to make any code changes to fix the issue that occured when CI tried to generate and attach the prebuilt binaries, + If you need to make any code changes to resolve the issue that occurred when CI tried to generate and attach the prebuilt binaries,Tools
LanguageTool
[style] ~16-~16: Consider using a different verb for a more formal wording.
Context: ...If you need to make any code changes to fix the issue that occured when CI tried to...(FIX_RESOLVE)
Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future. The current `-rc*` [prerelease_suffix](https://goreleaser.com/customization/git/#git) was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the [failing workflow](https://github.com/celestiaorg/celestia-app/actions/runs/10523365886/job/29157983992#step:6:68). This resolves by removing the `*`. ## Testing 1. Worked on my fork: https://github.com/rootulp/celestia-app/releases/tag/v2.1.2 2. Worked on this repo: https://github.com/celestiaorg/celestia-app/releases/tag/v2.1.2 ### Before ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2-rc1 previous_tag=v2.1.2-rc0 dirty=true ``` ### After ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2 previous_tag=v2.1.2-rc0 dirty=true ``` It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various [tag_sort](https://goreleaser.com/customization/git/?h=tag_sort#git) options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature. (cherry picked from commit 2931f15)
Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future. The current `-rc*` [prerelease_suffix](https://goreleaser.com/customization/git/#git) was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the [failing workflow](https://github.com/celestiaorg/celestia-app/actions/runs/10523365886/job/29157983992#step:6:68). This resolves by removing the `*`. ## Testing 1. Worked on my fork: https://github.com/rootulp/celestia-app/releases/tag/v2.1.2 2. Worked on this repo: https://github.com/celestiaorg/celestia-app/releases/tag/v2.1.2 ### Before ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2-rc1 previous_tag=v2.1.2-rc0 dirty=true ``` ### After ``` • git state commit=48173df3dc78f9348eedb3796f29ef9e9e5dc584 branch=HEAD current_tag=v2.1.2 previous_tag=v2.1.2-rc0 dirty=true ``` It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various [tag_sort](https://goreleaser.com/customization/git/?h=tag_sort#git) options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature.<hr>This is an automatic backport of pull request #3833 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <rootulp@gmail.com>
Prevents #3819 from happening again. Also adds a document so other maintainers can generate + upload prebuilt binaries if they don't work again in the future.
The current
-rc*prerelease_suffix was not working because goreleaser treated v2.1.2-rc1 as more recent than v2.1.2 in the failing workflow. This resolves by removing the*.Testing
Before
After
It is curious that it thinks the previous tag is v2.1.2-rc0 and not v2.1.2-rc1 but I couldn't fix with various tag_sort options. I think this only impacts Goreleaser changelog generation which we don't use b/c we use Github's auto generate release notes feature.