-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): forward port setting in the mergify.yml #3922
Conversation
📝 WalkthroughWalkthroughThe changes introduce two new rules to the Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/mergify.yml (1)
18-33
: Consider adding documentation for new labelsThe new rules successfully implement the forward-porting functionality as requested. To ensure proper usage, consider adding documentation or guidelines on how and when to apply the
forwardport:main
label to pull requests.This documentation could be added to the repository's contributing guidelines or README file to help developers understand and utilize this new feature effectively.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- .github/mergify.yml (1 hunks)
🔇 Additional comments (2)
.github/mergify.yml (2)
18-25
: LGTM: New rule for forward-porting from v1.x to mainThis new rule correctly implements the forward-porting functionality from the v1.x branch to the main branch. It uses the appropriate conditions and actions to achieve the desired behavior.
This addition aligns with the PR objectives and addresses the need outlined in issue #3917.
26-33
: LGTM: Consistent rule for forward-porting from v2.x to mainThis rule mirrors the structure of the v1.x rule, providing consistent behavior for forward-porting from the v2.x branch to the main branch. The consistency between these rules is commendable.
This addition completes the implementation of the forward-porting functionality as requested in the PR objectives and issue #3917.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #3917
Overview
It modifies mergify.yml.
By adding the
forwardport:main
tag to the v1.x or v2.x branch, it can forward-port it to the main branch.