-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move share encoding logic from core -> app #627
Conversation
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 29.78% 38.53% +8.75%
==========================================
Files 16 19 +3
Lines 2055 2543 +488
==========================================
+ Hits 612 980 +368
- Misses 1382 1478 +96
- Partials 61 85 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Can you add to the PR description a permalink to the source of the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Description
This PR moves the share encoding code from core to the app. It makes as few changes as possible, as to make the upcoming refactor for non-interactive defaults actually reviewable.
the code originally came from:
https://github.com/celestiaorg/celestia-core/blob/5c844685421fcb0ff328bba1752d080420002f41/types/shares.go
https://github.com/celestiaorg/celestia-core/blob/5c844685421fcb0ff328bba1752d080420002f41/types/shares_test.go
https://github.com/celestiaorg/celestia-core/blob/5c844685421fcb0ff328bba1752d080420002f41/types/share_splitting.go
https://github.com/celestiaorg/celestia-core/blob/5c844685421fcb0ff328bba1752d080420002f41/types/share_merging.go
closes: #623