feat: charge gas per message shares #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Nov 3, 2022
| payForDataGasDescriptor = "pay for data" | ||
|
|
||
| // GasPerMsgByte is the amount of gas to charge per byte of message data. | ||
| // TODO: extract GasPerMsgByte as a parameter to this module. |
rach-id
reviewed
Nov 3, 2022
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
==========================================
+ Coverage 26.13% 26.14% +0.01%
==========================================
Files 77 77
Lines 9353 9351 -2
==========================================
+ Hits 2444 2445 +1
+ Misses 6680 6677 -3
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
previously approved these changes
Nov 7, 2022
evan-forbes
approved these changes
Nov 8, 2022
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Closes celestiaorg#431 Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
rach-id
added a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Closes celestiaorg#431 Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431