Prevent double writes of samples to IPFS #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
commented
Apr 7, 2021
evan-forbes
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
I'd wait for another reviewer to comment before merging, but this LGTM 👍
IMO this closes #204 as well. Awesome find @Wondertan
liamsi
reviewed
Apr 7, 2021
liamsi
reviewed
Apr 7, 2021
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 62.27% 62.12% -0.16%
==========================================
Files 260 262 +2
Lines 23218 23359 +141
==========================================
+ Hits 14460 14512 +52
- Misses 7265 7329 +64
- Partials 1493 1518 +25
|
liamsi
approved these changes
Apr 7, 2021
This was referenced Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As we compute the NMT tree for columns and rows of shares in an extended data square, we end up adding all the shares into IPFS two times, thus introducing unnecessary overhead, especially for IO. Considering how big blocks may become and how quickly they are generated, the overhead would scale significantly.
Solution
The PR introduces a simple patch in NMTNodeAdder to memoize added leaves not to be added a second time.
EDIT:
It also fixes incorrect use of
BatchAdderEDIT2:
Closes #204