Define default configuration for embedded IPFS in FullNode #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
evan-forbes,
liamsi and
tac0turtle
as code owners
Wondertan
force-pushed
the
hlib/default-ipfs-config
branch
from
fde7f93 to
d2f5440
Compare
Wondertan
force-pushed
the
hlib/default-ipfs-config
branch
from
d2f5440 to
1f96496
Compare
Codecov Report
@@ Coverage Diff @@
## hlib/add-ipfs-cli #340 +/- ##
====================================================
Coverage ? 62.07%
====================================================
Files ? 263
Lines ? 22960
Branches ? 0
====================================================
Hits ? 14252
Misses ? 7190
Partials ? 1518 |
Wondertan
force-pushed
the
hlib/default-ipfs-config
branch
2 times, most recently
from
5cd0cf6 to
021b801
Compare
|
managed to get the e2e test to pass by increasing what I thought was already a long timeout. I don't really know the impact of the timeout on the validity of the test. evan-forbes@3e8fa2d |
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
Wondertan
force-pushed
the
hlib/default-ipfs-config
branch
from
021b801 to
07e2ede
Compare
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
liamsi
reviewed
May 19, 2021
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
|
@liamsi, can you pls in the future do reviews via one single review with a bunch of comments instead of multiple single comment reviews? |
|
Sure, can do 👌🏼 I was planning to only add one comment and then got sucked in and couldn't stop reading :-D |
evan-forbes
approved these changes
May 19, 2021
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
|
@liamsi, less spam |
|
@liamsi, all the comments addressed |
liamsi
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I went through every field in IPFS config and set what suits FullNode the best with documentation for every single field. We should also create a setup for LightNode and configuration for it accordingly
NOTE: The PR also sets Badger as default datastore