Reset celestia-core to tendermint master #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a possible data race/panic between processBlockchainCh and processPeerUpdates, since when we send to blockchainCh.Out in one goroutine and close the channel in the other. The race is seen in some Github Action runs. This commit fix the race, by adding a peerUpdatesCh as a bridge between processPeerUpdates and processBlockchainCh, so the former will send to this channel, the later will listen and forward the message to blockchainCh.Out channel. Updates #6516
state: move pruneBlocks function from consensus/state to state/execution Closes #5414
This PR make some tweaks to backfill after running e2e tests: - Separates sync and backfill as two distinct processes that the node calls. The reason is because if sync fails then the node should fail but if backfill fails it is still possible to proceed. - Removes peers who don't have the block at a height from the local peer list. As the process goes backwards if a node doesn't have a block at a height they're likely pruning blocks and thus they won't have any prior ones either. - Sleep when we've run out of peers, then try again.
Enabled the ASCII check linter https://github.com/tdakkota/asciicheck Closes #2801
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.22.0 to 1.23.0. - [Release notes](https://github.com/rs/zerolog/releases) - [Commits](rs/zerolog@v1.22.0...v1.23.0) --- updated-dependencies: - dependency-name: github.com/rs/zerolog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk
Updates #6557
Addresses #3931
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.1 to 1.8.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.7.1...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This pull request fixes 1 alert when merging fcca94a into ceaf5e5 - view on LGTM.com fixed alerts:
|
evan-forbes
changed the title
saw this in the super lint.
I think the `Sync` check covers our primary use case, and perhaps we can turn this back on in the future after some kind of event-system rewrite, or RPC rewrite that will avoid the serverside timeout.
|
How did this commit come into existence? fcca94a |
Closed
13 tasks
due to merging process taken in this PR, deleting everything 392c41f, then merging, there were a lot of missing files at the end. So I deleted everything again and then copy and pasted the entire tendermint directory back in. this approach is probably as hacky as it gets, but at the time I was just experimenting to try and save git histories while also resetting to tendermint master. |
This document attempts to capture and discuss some of the areas of Tendermint that seem to be cited as causing performance issue. I'm hoping to continue to gather feedback and input on this document to better understand what issues Tendermint performance may cause for our users. The overall goal of this document is to allow the maintainers and community to get a better sense of these issues and to be more capably able to discuss them and weight trade-offs about any proposed performance-focused changes. This document does not aim to propose any performance improvements. It does suggest useful places for benchmarks and places where additional metrics would be useful for diagnosing and further understanding Tendermint performance. Please comment with areas where my reasoning seems off or with additional areas that Tendermint performance may be causing user pain.
…6951) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.9.0 to 2.9.3. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml) - [Commits](vektra/mockery@v2.9.0...v2.9.3) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…elete-everything-then-merge
|
I can confirm that this branch as per 2104203 Let's re-apply (ideally cherry-pick?) all the changes we want to this branch in separate PRs. |
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 16, 2021
* Modify README.md - summarize LL and why it's useful - add banner - add further resources * Delet tokei.rs link seems down * Update README.md * Update community link * Update readme Go version badge. * Update community link * Update readme Go version badge. * Rebranding (#415) * new logo * Update README.md * review feedback * remove install + quick start sections as links are broken * finish rebrand and update golang Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Mustafa Al-Bassam <mustafa@lazyledger.io> Co-authored-by: John Adler <adlerjohn@users.noreply.github.com> Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
* Move consts, ipfs, and ipld to pkg (#508) * move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up * go mod tidy
This comment has been minimized.
This comment has been minimized.
|
closing in favor of #534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is like hitting the reset button and eliminating all merge conflicts with tendermint master.
steps taken:
this PR does not have any celestia-core specific code yet, we still have to copy paste that back in
Closes: #XXX