fix returned shares order in case error is returned from GetLeavesByN…

…amespace

share/get.go

@@ -3,12 +3,11 @@ package share
 import (
  "context"
 
+ "github.com/celestiaorg/celestia-node/share/ipld"
+ "github.com/celestiaorg/nmt/namespace"
  "github.com/ipfs/go-blockservice"
  "github.com/ipfs/go-cid"
  format "github.com/ipfs/go-ipld-format"
-
- "github.com/celestiaorg/celestia-node/share/ipld"
- "github.com/celestiaorg/nmt/namespace"
 )
 
 // GetShare fetches and returns the data for leaf `leafIndex` of root `rootCid`.
@@ -59,10 +58,10 @@ func GetSharesByNamespace(
  return nil, err
  }
 
- shares := make([]Share, 0, maxShares)
- for _, leaf := range leaves {
+ shares := make([]Share, len(leaves))
+ for i, leaf := range leaves {
  if leaf != nil {
- shares = append(shares, leafToShare(leaf))
+ shares[i] = leafToShare(leaf)
  }
  }