consistent share naming

celestiaorg · Jun 26, 2023 · cedb940 · cedb940
1 parent 2282bd2
commit cedb940
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/blob/helper.go b/blob/helper.go
@@ -19,8 +19,8 @@ func SharesToBlobs(rawShares []share.Share) ([]*Blob, error) {
  }
 
  appShares := make([]shares.Share, 0, len(rawShares))
- for _, sh := range rawShares {
- bShare, err := shares.NewShare(sh)
+ for _, shr := range rawShares {
+ bShare, err := shares.NewShare(shr)
  if err != nil {
  return nil, err
  }

diff --git a/blob/service.go b/blob/service.go
@@ -208,8 +208,8 @@ func (s *Service) getByCommitment(
  // reconstruct the `blobShare` from the first rawShare in range
  // in order to get blob's length(first share will contain this info)
  if blobShare == nil {
- for i, sh := range rawShares {
- bShare, err := shares.NewShare(sh)
+ for i, shr := range rawShares {
+ bShare, err := shares.NewShare(shr)
  if err != nil {
  return nil, nil, err
  }

diff --git a/share/getter.go b/share/getter.go
@@ -80,8 +80,8 @@ func (ns NamespacedShares) Verify(root *Root, namespace Namespace) error {
 func (row *NamespacedRow) verify(rowRoot []byte, namespace Namespace) bool {
  // construct nmt leaves from shares by prepending namespace
  leaves := make([][]byte, 0, len(row.Shares))
- for _, sh := range row.Shares {
- leaves = append(leaves, append(GetNamespace(sh), sh...))
+ for _, shr := range row.Shares {
+ leaves = append(leaves, append(GetNamespace(shr), shr...))
  }
 
  // verify namespace

diff --git a/share/ipld/get_shares_test.go b/share/ipld/get_shares_test.go
@@ -371,8 +371,8 @@ func TestGetSharesWithProofsByNamespace(t *testing.T) {
 
  // construct nodes from shares by prepending namespace
  var leaves [][]byte
- for _, sh := range rowShares {
- leaves = append(leaves, append(share.GetNamespace(sh), sh...))
+ for _, shr := range rowShares {
+ leaves = append(leaves, append(share.GetNamespace(shr), shr...))
  }
 
  // verify namespace