Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: Add Peers method #1449

Closed
Tracked by #1397
Wondertan opened this issue Dec 7, 2022 · 0 comments · Fixed by #1451
Closed
Tracked by #1397

discovery: Add Peers method #1449

Wondertan opened this issue Dec 7, 2022 · 0 comments · Fixed by #1451
Assignees
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Dec 7, 2022

We decided to rely on existing discovery primitives. It is a single-purpose mechanism providing the API for
FN/BNs to advertise themselves, s.t. other LN/FN/BNs can discover and ensure N connections to them. However, the
current API does not let us know our discovered FN/BN peers' connections. A listing of discovered peers is required for
ShrEx/EDS and ShrEx/ND, as their clients do not discover servers automatically and expect them to be provided.

Subsequently, we extend discovery.Discovery with the following method:

// Peers provides a list of discovered peers in the "full" topic.
// If Discovery hasn't found any peers, it blocks until at least one peer is found.
func (d *Discovery) Peers(context.Context) ([]peer.ID, error)
@Wondertan Wondertan added area:shares Shares and samples and removed needs:triage labels Dec 7, 2022
vgonkivs added a commit that referenced this issue Dec 9, 2022
## Overview
Resolves #1449 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Co-authored-by: Ryan <ryan@celestia.org>
renaynay pushed a commit to renaynay/celestia-node that referenced this issue Dec 9, 2022
## Overview
Resolves celestiaorg#1449 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Co-authored-by: Ryan <ryan@celestia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants