Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modheader: GetByHeight should account for lag on the networkHead #2357

Closed
Wondertan opened this issue Jun 12, 2023 · 0 comments · Fixed by #2362
Closed

modheader: GetByHeight should account for lag on the networkHead #2357

Wondertan opened this issue Jun 12, 2023 · 0 comments · Fixed by #2362
Assignees
@Wondertan
Labels
area:header Extended header

Comments

@Wondertan
Copy link
Member

Since #2173, we accommodate for +1 network lag in the GetByHeight, but we do it only on checking the local head, while we must also do it for the network head, as otherwise, it's not effective.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wondertan Wondertan

Labels
area:header Extended header
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(header): GetByHeight requests for syncer head +1 shouldnt error celestiaorg/celestia-node
1 participant
@Wondertan