Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): GetByHeight requests for syncer head +1 shouldnt error #2362

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Jun 13, 2023

#2173 missed a +1 check on the syncer head

Closes #2357

@distractedm1nd distractedm1nd added area:header Extended header kind:fix Attached to bug-fixing PRs labels Jun 13, 2023
@distractedm1nd distractedm1nd self-assigned this Jun 13, 2023
@distractedm1nd distractedm1nd marked this pull request as ready for review June 13, 2023 10:48
@codecov-commenter
Copy link

Codecov Report

Merging #2362 (0fa62c6) into main (c9443c6) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
+ Coverage   50.86%   50.91%   +0.05%     
==========================================
  Files         154      154              
  Lines        9742     9742              
==========================================
+ Hits         4955     4960       +5     
+ Misses       4350     4347       -3     
+ Partials      437      435       -2     
Impacted Files Coverage Δ
nodebuilder/header/service.go 7.69% <0.00%> (ø)

... and 3 files with indirect coverage changes

@Wondertan
Copy link
Member

Closes #2357

nodebuilder/tests/api_test.go Show resolved Hide resolved
@distractedm1nd distractedm1nd enabled auto-merge (squash) June 14, 2023 10:12
@distractedm1nd distractedm1nd merged commit f291cf3 into main Jun 14, 2023
@distractedm1nd distractedm1nd deleted the syncerheadplusone branch June 14, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modheader: GetByHeight should account for lag on the networkHead
4 participants