Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the setting of statuses for spans to their corresponding methods #3793

Open
rach-id opened this issue Oct 2, 2024 · 0 comments
Open

move the setting of statuses for spans to their corresponding methods #3793

rach-id opened this issue Oct 2, 2024 · 0 comments
Assignees
@Wondertan
Labels
external Issues created by non node team members needs:triage

Comments

@rach-id
Copy link
Member

rach-id commented Oct 2, 2024 

          tracing: Ok status should be set once on success.

Currently, it's written always by default, while error cases do not overwrite it, so error op may show as success.

Originally posted by @Wondertan in #3633 (comment)
@rach-id rach-id mentioned this issue Oct 2, 2024
Merged
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Oct 2, 2024
@renaynay renaynay changed the title move the statuses to their corresponding methods move the setting of statuses for spans to their corresponding methods Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wondertan Wondertan

Labels
external Issues created by non node team members needs:triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wondertan @rach-id