Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keep using the namespace proof for GetBlob and GetAll #3633

Merged
merged 8 commits into from
Oct 2, 2024
Merged

feat: keep using the namespace proof for GetBlob and GetAll #3633

merged 8 commits into from
Oct 2, 2024

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 7, 2024

Closes #3629

@rach-id rach-id marked this pull request as draft August 7, 2024 16:59
@github-actions github-actions bot added the external Issues created by non node team members label Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature_branch_blob_proof@32d3137). Learn more about missing BASE report.

Files with missing lines Patch % Lines
blob/service.go 80.00% 13 Missing and 5 partials ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##             feature_branch_blob_proof    #3633   +/-   ##
============================================================
  Coverage                             ?   45.85%           
============================================================
  Files                                ?      281           
  Lines                                ?    16172           
  Branches                             ?        0           
============================================================
  Hits                                 ?     7415           
  Misses                               ?     7903           
  Partials                             ?      854

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rach-id rach-id marked this pull request as ready for review August 7, 2024 17:33
@cristaloleg cristaloleg added the kind:feat Attached to feature PRs label Oct 2, 2024
Wondertan
Wondertan reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly tracing nits

blob/service.go Show resolved Hide resolved
blob/service.go Outdated Show resolved Hide resolved
blob/service.go Outdated Show resolved Hide resolved
rach-id and others added 2 commits October 2, 2024 14:54
@rach-id @Wondertan
Update blob/service.go
055ebf8 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
@rach-id @Wondertan
Update blob/service.go
6a8b25b 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
@Wondertan Wondertan merged commit d3e653a into celestiaorg:feature_branch_blob_proof Oct 2, 2024
27 of 28 checks passed
@rach-id rach-id mentioned this pull request Oct 2, 2024
Open
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Dec 9, 2024
@rach-id @Wondertan @vgonkivs
feat: keep using the namespace proof for GetBlob and GetAll (celestia…
dbe15c8 
…org#3633)

Closes celestiaorg#3629

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs left review comments

@cristaloleg cristaloleg cristaloleg approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

Assignees

@rach-id rach-id

Labels
external Issues created by non node team members kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rach-id @codecov-commenter @cristaloleg @Wondertan @vgonkivs