Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keep using the namespace proof for GetBlob and GetAll #3633

Open
wants to merge 4 commits into
base: feature_branch_blob_proof
Choose a base branch
from
Open

feat: keep using the namespace proof for GetBlob and GetAll #3633

wants to merge 4 commits into from

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 7, 2024

Closes #3629

@rach-id rach-id marked this pull request as draft August 7, 2024 16:59
@github-actions github-actions bot added the external Issues created by non node team members label Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature_branch_blob_proof@32d3137). Learn more about missing BASE report.

Files Patch % Lines
blob/service.go 80.00% 13 Missing and 5 partials ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##             feature_branch_blob_proof    #3633   +/-   ##
============================================================
  Coverage                             ?   45.92%           
============================================================
  Files                                ?      281           
  Lines                                ?    16172           
  Branches                             ?        0           
============================================================
  Hits                                 ?     7427           
  Misses                               ?     7884           
  Partials                             ?      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rach-id rach-id marked this pull request as ready for review August 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg left review comments

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

Assignees
No one assigned
Labels
external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rach-id @codecov-commenter @cristaloleg