Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the blob endpoints not to query the EDS on every get #3629

Open
rach-id opened this issue Aug 6, 2024 · 0 comments
Open

Improve the blob endpoints not to query the EDS on every get #3629

rach-id opened this issue Aug 6, 2024 · 0 comments
Assignees
@rach-id
Labels
external Issues created by non node team members needs:triage

Comments

@rach-id
Copy link
Member

rach-id commented Aug 6, 2024

As of #3610, we query the EDS everytime when getting the proof for a blob.

This might lead to degraded performance. We can improve on only using that type of proof when GetProof. Otherwise, we keep just verifying the inclusion of the namespace.
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Aug 6, 2024
@rach-id rach-id self-assigned this Aug 7, 2024
@rach-id rach-id mentioned this issue Aug 7, 2024
Merged
Wondertan added a commit that referenced this issue Oct 2, 2024
@rach-id @Wondertan
feat: keep using the namespace proof for GetBlob and GetAll (#3633)
d3e653a 
Closes #3629

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this issue Dec 9, 2024
@rach-id @Wondertan @vgonkivs
feat: keep using the namespace proof for GetBlob and GetAll (celestia…
dbe15c8 
…org#3633)

Closes celestiaorg#3629

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
external Issues created by non node team members needs:triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id