refactor(nodebuilder): moving service/<service> services to respective node sub-packages #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
architecture
Codecov Report
@@ Coverage Diff @@
## node-refactorings #1056 +/- ##
====================================================
Coverage ? 61.59%
====================================================
Files ? 150
Lines ? 8524
Branches ? 0
====================================================
Hits ? 5250
Misses ? 2815
Partials ? 459 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
distractedm1nd
requested review from
liamsi,
renaynay,
Wondertan and
vgonkivs
as code owners
distractedm1nd
force-pushed
the
service-migration
branch
from
a59da13
to
77f9dbf
Compare
Wondertan
reviewed
Sep 26, 2022
Wondertan
reviewed
Sep 27, 2022
distractedm1nd
force-pushed
the
service-migration
branch
from
0cc8e42
to
cf3296a
Compare
vgonkivs
reviewed
Sep 29, 2022
Wondertan
reviewed
Sep 30, 2022
Wondertan
reviewed
Sep 30, 2022
Wondertan
previously approved these changes
Sep 30, 2022
|
Hmm too many CI issues @distractedm1nd |
…g service/state to root
…dule and interfaces to Module
…of LC while removing start/stop from interfaces
distractedm1nd
force-pushed
the
service-migration
branch
from
11b9ea3
to
1df9976
Compare
|
All tests pass for me locally, let's see if something flakes |
Wondertan
approved these changes
Sep 30, 2022
walldiss
approved these changes
Sep 30, 2022
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 7, 2022
…e node sub-packages (celestiaorg#1056)
Bidon15
added a commit
that referenced
this pull request
Oct 7, 2022
Getting address from node's account This is a handy feature that testground's tests are already utilising in upcoming PFD test-plans Ref: #1056 #506 External Ref: celestiaorg/test-infra#33
distractedm1nd
added a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Oct 26, 2022
…pi/gateway` (celestiaorg#1175) Based on celestiaorg#1056
distractedm1nd
added a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Oct 26, 2022
…pi/gateway` (celestiaorg#1175) Based on celestiaorg#1056
distractedm1nd
added a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Oct 28, 2022
…pi/gateway` (celestiaorg#1175) Based on celestiaorg#1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves services into
nodebuilderand makes the internal structs private, offering a public interface instead.Closes #960
Packages:
RPCI took the branch from @renaynay's remote and pushed it to our remote here so that the diffs will be clear. #997 can then rebase off of that branch when things get merged into it.
Leaving RPC out of things since it will be ripped out anyways. Should we at least move it to the root though?