refactor(ipld): use Set/GetCell API from rstm2d #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs and
distractedm1nd
as code owners
|
The race tests will fail here until celestiaorg/rsmt2d#128 is merged and released |
Wondertan
force-pushed
the
hlib/rsmt2d-api-update
branch
from
f9e7e18
to
7051382
Compare
distractedm1nd
suggested changes
Oct 7, 2022
renaynay
reviewed
Oct 10, 2022
Wondertan
force-pushed
the
hlib/rsmt2d-api-update
branch
from
7051382
to
b3a49eb
Compare
|
Rebased on main |
distractedm1nd
previously approved these changes
Nov 11, 2022
The latest rsmt2d version allows us to set cells/share directly into the imported square. Hence, we can avoid using flattened slices and the complexity it introduces when calculating position or index to set a share. Also, we now avoid reimporting the square on each repair retry and overall optimizing the whole process.
Wondertan
dismissed stale reviews from distractedm1nd and walldiss
via
d6704aa
Wondertan
force-pushed
the
hlib/rsmt2d-api-update
branch
from
b3a49eb
to
d6704aa
Compare
distractedm1nd
approved these changes
Nov 11, 2022
vgonkivs
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest rsmt2d version allows us to set cells/share directly into the imported square. Hence, we can avoid using flattened slices and the complexity it introduces when calculating position or index to set a share. Also, we now avoid reimporting the square on each repair retry and overall optimizing the whole process.
Closes #824
Blocked on celestiaorg/rsmt2d#127 and celestiaorg/rsmt2d#128