refactor(daser): use functional options pattern to configure daser

[derrandz]

Overview

The DAS module is currently reliant on default constant global variables acting as configuration variables.

This makes changing configuration values for the DAS module non-trivial, as it requires code changes and binary re-building.

In this PR, we refactor the global configuration variables used in the DAS module to use the functional options pattern, which will trivialize the process of configuring a Celestia node.

Reference Issue

#1063
#709

Impact / Change

The das package is now configurable using a set of functional options, namely:

WithSamplingRange(uint64)
WithConcurrencyLimit(int)
WithBackgroundStoreInterval(time.Duration)
WithPrioritySizeQueue(int)
WithGenesisHeight)

This allows the das package to be configured with values other than the default parameters defined in das/options.go:29

An example of the das package being configured with these options and instantiated with them is: nodebuilder/das/module.go:22

Owners

@derrandz

[walldiss]

Looks good to me. Like your functional approach with options to remove dependancy on nodebuilder. There are 2 things that I think could be improved:

• types in structs could be better aligned with their usage to avoid extra conversions.
• we need to set up default values inside DASer in case missing options scenario.

Besides that looks legit.

[derrandz]

@walldiss I've addressed your comments about typing to do away with conversions in operations, however, I would still like to understand why are the compared-with variables uint64s to begin with? variables like networkHead and so on.

[codecov-commenter]

Codecov Report

Merging #1225 (6793a3f) into main (f4e582e) will decrease coverage by 0.66%.
The diff coverage is 70.63%.

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   56.34%   55.68%   -0.67%     
==========================================
  Files         160      164       +4     
  Lines        9935    10079     +144     
==========================================
+ Hits         5598     5612      +14     
- Misses       3783     3906     +123     
- Partials      554      561       +7     

Impacted Files	Coverage Δ
nodebuilder/das/opts.go	0.00% <ø> (ø)
nodebuilder/module.go	100.00% <ø> (ø)
nodebuilder/settings.go	0.00% <0.00%> (ø)
das/options.go	53.96% <53.96%> (ø)
nodebuilder/das/config.go	70.00% <70.00%> (ø)
das/daser.go	65.21% <75.00%> (-1.07%)	⬇️
das/state.go	95.51% <94.11%> (+0.05%)	⬆️
das/coordinator.go	92.64% <100.00%> (ø)
nodebuilder/config.go	86.11% <100.00%> (+0.39%)	⬆️
nodebuilder/das/daser.go	100.00% <100.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[renaynay]

Also @derrandz can you check all your godocs on the methods you've implemented and make it according to godoc style?

for example:

// Type Parameters .....
type Parameters struct {

should be

// Parameters .....
type Parameters struct {

[Wondertan]

Thanks for bringing this over the finish line. This PR was a great way for us to develop the configuration pattern for our codebase and get everyone onboarded with it.

[walldiss]

Looks amazing, Great work!