Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restricting PFD metrics to successful PFDs #1255

Merged

Conversation

distractedm1nd
Copy link
Collaborator

Closes #1254

@codecov-commenter
Copy link

Codecov Report

Merging #1255 (2ca2b7d) into main (a1ca665) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   56.16%   56.08%   -0.09%     
==========================================
  Files         161      161              
  Lines        9880     9884       +4     
==========================================
- Hits         5549     5543       -6     
- Misses       3781     3789       +8     
- Partials      550      552       +2     
Impacted Files Coverage Δ
state/core_access.go 16.73% <0.00%> (-0.28%) ⬇️
header/core/listener.go 52.83% <0.00%> (-5.67%) ⬇️
fraud/bad_encoding.go 63.00% <0.00%> (-3.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@distractedm1nd distractedm1nd merged commit 1ba85ed into celestiaorg:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(state/metrics): PFDs counted even when unsuccessful
5 participants