Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core/fetcher): Improve error messages for fetcher methods #1263

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

renaynay
Copy link
Member

Self-explanatory (found by @jbowen93)

@renaynay renaynay added area:core_and_app Relationship with Core node and Celestia-App kind:misc Attached to miscellaneous PRs labels Oct 24, 2022
@renaynay renaynay self-assigned this Oct 24, 2022
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to make an error type in here, but it definitely not worth doing it now

@renaynay renaynay merged commit 09b48a3 into celestiaorg:main Oct 24, 2022
@renaynay renaynay deleted the fetcher-errors branch October 24, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core_and_app Relationship with Core node and Celestia-App kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants