refactor(nodebuilder): Allow custom networks to work over already-initialised store #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
previously approved these changes
Oct 24, 2022
jbowen93
previously approved these changes
Oct 24, 2022
distractedm1nd
previously approved these changes
Oct 24, 2022
renaynay
dismissed stale reviews from distractedm1nd, jbowen93, and Wondertan
via
3caad63
renaynay
force-pushed
the
remove-error-customnet-init
branch
from
5ae120d
to
3caad63
Compare
distractedm1nd
approved these changes
Oct 24, 2022
vgonkivs
approved these changes
Oct 24, 2022
Wondertan
approved these changes
Oct 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 56.17% 56.15% -0.02%
==========================================
Files 160 160
Lines 9939 9935 -4
==========================================
- Hits 5583 5579 -4
Misses 3802 3802
Partials 554 554
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After conversation with @jbowen93 , we decided to allow using custom networks over an already-initialised node store.
The issue this was originally attempting to prevent is accidental corruption of chain data in the case that a user accidentally leaves their environment variable set up and connects to another network over an old node store.
This issue is actually currently prevented thanks to #1073 extending the node store name with the network name.