Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: update go-acc version due to errors and new release #1281

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Makefile: update go-acc version due to errors and new release #1281

merged 1 commit into from
Oct 28, 2022

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 25, 2022

I was getting the following errors on v0.2.6 of go-acc. Updating to latest fixed these errors.

celestia-node % make cover
--> Generating Code Coverage
go install github.com/ory/go-acc@v0.2.6
# golang.org/x/sys/unix
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:121:3: too many errors
make: *** [cover] Error 2

@Wondertan Wondertan added the kind:deps Pull requests that update a dependency file label Oct 26, 2022
@MSevey
Copy link
Member Author

MSevey commented Oct 26, 2022

This happen on golang 19.1 and 19.2 fwiw

@MSevey MSevey self-assigned this Oct 26, 2022
@Wondertan Wondertan merged commit 2a1c585 into main Oct 28, 2022
@Wondertan Wondertan deleted the sevey/go-acc-latest branch October 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@MSevey MSevey

Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSevey @Wondertan @vgonkivs @renaynay