refactor: changing nodebuilder/<pkg>/service.go to <pkg>.go

[distractedm1nd]

Closes #1278

[codecov-commenter]

Codecov Report

Merging #1301 (ba66974) into main (b4a8145) will increase coverage by 0.02%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
+ Coverage   55.28%   55.30%   +0.02%     
==========================================
  Files         180      181       +1     
  Lines       10904    10962      +58     
==========================================
+ Hits         6028     6063      +35     
- Misses       4276     4298      +22     
- Partials      600      601       +1     

Impacted Files	Coverage Δ
nodebuilder/core/constructors.go	100.00% <ø> (ø)
nodebuilder/das/constructors.go	75.00% <ø> (ø)
nodebuilder/gateway/constructors.go	0.00% <ø> (ø)
nodebuilder/header/service.go	57.14% <ø> (ø)
share/empty.go	100.00% <ø> (ø)
nodebuilder/header/constructors.go	71.42% <71.42%> (ø)
nodebuilder/p2p/p2p.go	85.18% <85.18%> (ø)
api/rpc/client/client.go	78.57% <100.00%> (+0.79%)	⬆️
nodebuilder/p2p/flags.go	67.46% <100.00%> (ø)
nodebuilder/p2p/host.go	90.90% <100.00%> (+9.65%)	⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[derrandz]

Just a nit, and a few questions, and discussion openers.

[distractedm1nd]

Tests are failing (new races) but they are unrelated

[renaynay]

one last comment

[Wondertan]

LGTM, but let's keep those constructors private