-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): fraud.Proof
(un)marshalling and subscription as chan
#1307
fix(rpc): fraud.Proof
(un)marshalling and subscription as chan
#1307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
- Coverage 55.81% 54.57% -1.24%
==========================================
Files 170 177 +7
Lines 10254 10595 +341
==========================================
+ Hits 5723 5782 +59
- Misses 3962 4239 +277
- Partials 569 574 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6f75e7d
to
3a8b236
Compare
Note to myself: create an issue to avoid double (un)marshaling of Proof |
fb2fcac
to
9c664eb
Compare
Now closes #1303 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and just nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those nits are optional, so approving
6e9a4af
6e9a4af
to
041cf6d
Compare
Closes #1208 (when combined with #1292), and closes #1207. Also closes #1303